Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reset css to our remix project #4901

Merged
merged 13 commits into from
Feb 15, 2024
Merged

Add a reset css to our remix project #4901

merged 13 commits into from
Feb 15, 2024

Conversation

liady
Copy link
Contributor

@liady liady commented Feb 14, 2024

This adds a normalize.css file to reset our remix app style. It fixes the 'jump' issue on popups

Copy link
Contributor

github-actions bot commented Feb 14, 2024

Try me

Copy link

relativeci bot commented Feb 14, 2024

Job #10446: Bundle Size — 61.88MiB (+0.22%).

cb573bc(current) vs d299c8d master#10444(baseline)

Important

Bundle introduced 3 duplicate packages – View changed duplicate packages

Warning

Bundle introduced 11 new packages: antd, omit.js, rc-pagination and 8 more – View changed packages

Bundle metrics  Change 6 changes Regression 3 regressions Improvement 1 improvement
                 Current
Job #10446
     Baseline
Job #10444
Regression  Initial JS 34.93MiB(+0.39%) 34.79MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 30.9% 20.46%
No change  Chunks 28 28
No change  Assets 32 32
Change  Modules 4361(+1.56%) 4294
No change  Duplicate Modules 493 493
Improvement  Duplicate Code 30.94%(-0.19%) 31%
Regression  Packages 469(+3.08%) 455
Regression  Duplicate Packages 60(+5.26%) 57
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #10446
     Baseline
Job #10444
Regression  JS 61.87MiB (+0.22%) 61.73MiB
Improvement  HTML 11.37KiB (-0.32%) 11.41KiB

View job #10446 reportView fix/normalize-css branch activityView project dashboard

Copy link
Contributor

Performance test results:
(Chart1)
(Chart2)

@liady liady merged commit 6018050 into master Feb 15, 2024
16 checks passed
@liady liady deleted the fix/normalize-css branch February 15, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants